This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Banking Stage drop too_old votes#19400
Closed
tao-stones wants to merge 1 commit intosolana-labs:masterfrom
Closed
Conversation
… vote_state; 2. banking_stage calls above function after accounts were locked, and before calling bank.load_and_execute_transactions, redundant vote transactions are marked as TransactionError::ProcessedAlready in result;
Contributor
Author
|
Create this PR from #19152 to check why CI fails on Stable test, which succeeds locally. |
Contributor
Author
|
this is a duplicate of #19152 |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
stale
Bot
added
the
stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
banking_stage inserts all Vote transactions, includes
TooOldvotes, into bank. Those redundant votes should be dropped.Summary of Changes
add check_redundant_votes function to check vote by current bank's vote_state;
banking_stage calls above function after accounts were locked, and before
calling bank.load_and_execute_transactions, redundant vote transactions
are marked as TransactionError::ProcessedAlready in result;
Fixes #17877