This repository was archived by the owner on Jan 22, 2025. It is now read-only.
stake: Remove v2 program references#19308
Merged
joncinque merged 2 commits intosolana-labs:masterfrom Aug 20, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19308 +/- ##
=========================================
- Coverage 82.8% 82.8% -0.1%
=========================================
Files 458 458
Lines 130847 130646 -201
=========================================
- Hits 108453 108225 -228
- Misses 22394 22421 +27 |
Contributor
Removing the feature flag itself is fine as well. Do you need the v1.7 backport on this PR though? |
Contributor
Author
Done,
Yes, since it's a prereq for #19309 |
mergify Bot
pushed a commit
that referenced
this pull request
Aug 20, 2021
* stake: Remove v2 program references * Remove stake v2 feature, along with stake rewrite (cherry picked from commit 73aa004) # Conflicts: # runtime/src/bank.rs
mergify Bot
added a commit
that referenced
this pull request
Aug 20, 2021
* stake: Remove v2 program references (#19308) * stake: Remove v2 program references * Remove stake v2 feature, along with stake rewrite (cherry picked from commit 73aa004) # Conflicts: # runtime/src/bank.rs * Fix merge conflict * Fix uses of old `stake` function Co-authored-by: Jon Cinque <jon.cinque@gmail.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
While doing work on
credits_observed, it made sense to also eliminate thefix_stake_deactivateflag everywhere, enabled in slot 55728001. This will make it easier to read the other (coming) PR.Summary of Changes
Remove references to stake program v2, but NOT the feature itself, so that it can still be queried with
solana feature status. Let me know if it makes sense to remove that too.Note that this PR makes no logic changes at all, for your reviewing pleasure.