This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Re-enable fixed tests#1907
Merged
carllin merged 1 commit intosolana-labs:masterfrom Nov 26, 2018
Merged
Conversation
sambley
approved these changes
Nov 26, 2018
tao-stones
pushed a commit
to tao-stones/solana
that referenced
this pull request
Jul 1, 2024
…abs#1882) (solana-labs#1907) Deprecate --rocksdb-shred-compaction fifo (solana-labs#1882) The fifo compaction option was originally added to mitigate write stalls that were occurring with level compaction. Since fifo was introduced, the level compaction implementation has been optimized to reduce I/O amplification. With these improvements, level and fifo are comparable and sticking with level only simplifies things. For now, only a deprecation warning will be printed. In the next release branch (2.1.0), specifying fifo will be an error (cherry picked from commit e15e235) Co-authored-by: steviez <steven@anza.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Tests were ignored after fix was pushed in an earlier PR: #1888
Summary of Changes
Re-enable tests
Fixes #