Fix caller write privileges for native cpi

[jstarry]

Problem

Caller write privileges are not created correctly for native cpi. The caller_write_privileges vector should match up with message.account_keys because they will be indexed the same.

Summary of Changes

• Remove incorrect write privilege value insertion
• Match up write privileges vector with the accounts vector built from message.account_keys

Fixes #

[jstarry]

Since native_invoke is only called for the bpf upgradeable program and that program doesn't modify caller accounts before invoking the native create account instruction, there shouldn't be any change of behavior here.

[jackcmay]

Do you have a test that highlights the issue?

[jstarry]

Not yet, just running through CI first to see what pops up. Should have opened as draft

[codecov]

Codecov Report

Merging #18616 (8cefd9a) into master (3e16df8) will increase coverage by 0.1%.
The diff coverage is 89.8%.

@@            Coverage Diff            @@
##           master   #18616     +/-   ##
=========================================
+ Coverage    82.6%    82.7%   +0.1%     
=========================================
  Files         437      440      +3     
  Lines      122557   123897   +1340     
=========================================
+ Hits       101288   102527   +1239     
- Misses      21269    21370    +101     

[jstarry]

Hmm looks like there aren't any tests for native cpi yet beyond bpf loader integration tests, I don't have the time to put a test suite together right now so I'll write up an issue instead.

[jstarry]

Issue here: #18629