This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Refactoring: Unify account_deps and accounts#17898
Merged
Lichtso merged 11 commits intosolana-labs:masterfrom Jul 5, 2021
Merged
Refactoring: Unify account_deps and accounts#17898Lichtso merged 11 commits intosolana-labs:masterfrom
Lichtso merged 11 commits intosolana-labs:masterfrom
Conversation
Lichtso
force-pushed
the
refactor/unify_account_deps
branch
2 times, most recently
from
d4b350c to
06119f3
Compare
Codecov Report
@@ Coverage Diff @@
## master #17898 +/- ##
=======================================
Coverage 82.3% 82.3%
=======================================
Files 433 433
Lines 121157 121163 +6
=======================================
+ Hits 99813 99827 +14
+ Misses 21344 21336 -8 |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
stale
Bot
added
the
stale
Lichtso
removed
the
stale
Lichtso
force-pushed
the
refactor/unify_account_deps
branch
2 times, most recently
from
b69a46d to
0964dc7
Compare
Lichtso
force-pushed
the
refactor/unify_account_deps
branch
from
3fd3ec0 to
0d35872
Compare
Lichtso
force-pushed
the
refactor/unify_account_deps
branch
from
038de3d to
e46ed5b
Compare
Lichtso
force-pushed
the
refactor/unify_account_deps
branch
from
736faba to
d619984
Compare
mergify Bot
pushed a commit
that referenced
this pull request
Jul 7, 2021
* Changes ThisInvokeContext::get_account() to use accounts instead of pre_accounts. * Adds explicit keys to accounts to make them symmetric to account_deps. * Appends account_deps to accounts in transaction loading and removes account_deps everywhere else. (cherry picked from commit 7462c27) # Conflicts: # program-test/src/lib.rs # runtime/src/bank.rs # runtime/src/message_processor.rs
mergify Bot
added a commit
that referenced
this pull request
Jul 7, 2021
* Refactoring: Unify account_deps and accounts (#17898) * Changes ThisInvokeContext::get_account() to use accounts instead of pre_accounts. * Adds explicit keys to accounts to make them symmetric to account_deps. * Appends account_deps to accounts in transaction loading and removes account_deps everywhere else. (cherry picked from commit 7462c27) # Conflicts: # program-test/src/lib.rs # runtime/src/bank.rs # runtime/src/message_processor.rs * fix conflicts Co-authored-by: Alexander Meißner <AlexanderMeissner@gmx.net> Co-authored-by: Justin Starry <justin@solana.com>
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
account_depstravel along slightly different code paths than the "normal"accountsdo.This makes mapping
accountsinto the VM memory harder and should thus be resolved first.Summary of Changes
ThisInvokeContext::get_account()to useaccountsinstead ofpre_accounts. So now, thepre_accountsare only used inMessageProcessor::verify_and_update()andMessageProcessor::verify().accountsas tuples, the same way as it is withaccount_deps.account_depsat the end of theaccountsslice and use themessage.account_keys.len()as border between both subslices / ranges.Fixes #