Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

add prev_id to Entry, PohEntry#1783

Merged
rob-solana merged 1 commit intosolana-labs:masterfrom
rob-solana:entry.last_id
Nov 13, 2018
Merged

add prev_id to Entry, PohEntry#1783
rob-solana merged 1 commit intosolana-labs:masterfrom
rob-solana:entry.last_id

Conversation

@rob-solana
Copy link
Copy Markdown
Contributor

@rob-solana rob-solana commented Nov 12, 2018

Problem

the forking bank can't identify from an Entry how to chain it to any previous Entries, only a single PoH chain is supported

Summary of Changes

add prev_id to Entry and PohEntry to serve as a "previous" pointer in PoH

Fixes #

@garious
Copy link
Copy Markdown
Contributor

garious commented Nov 12, 2018

If used to form a linked list, how about prev_id? The term last_id was intended to mean the last item in a list. The last_ids queue, for example, should be renamed to recent_ids where the most recent one is the last_id.

@rob-solana
Copy link
Copy Markdown
Contributor Author

thanks for the name

@rob-solana rob-solana changed the title add last_id to Entry, PohEntry add prev_id to Entry, PohEntry Nov 13, 2018
@rob-solana rob-solana merged commit fa72160 into solana-labs:master Nov 13, 2018
@rob-solana rob-solana deleted the entry.last_id branch November 13, 2018 01:03
vkomenda referenced this pull request in vkomenda/solana Aug 29, 2021
Bumps [start-server-and-test](https://github.com/bahmutov/start-server-and-test) from 1.12.1 to 1.12.3.
- [Release notes](https://github.com/bahmutov/start-server-and-test/releases)
- [Commits](bahmutov/start-server-and-test@v1.12.1...v1.12.3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
wen-coding pushed a commit to wen-coding/solana that referenced this pull request Jun 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants