This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Remove unnecessary code#17559
Merged
jeffwashington merged 1 commit intosolana-labs:masterfrom May 28, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #17559 +/- ##
=======================================
Coverage 82.6% 82.6%
=======================================
Files 427 427
Lines 119189 119183 -6
=======================================
+ Hits 98541 98542 +1
+ Misses 20648 20641 -7 |
ryoqun
reviewed
May 28, 2021
| .get_snapshot_storages(self.slot()) | ||
| .into_iter() | ||
| .collect() | ||
| self.rc.get_snapshot_storages(self.slot()) |
Contributor
There was a problem hiding this comment.
so this was unnecessary in the first place.. https://github.com/solana-labs/solana/pull/8339/files#diff-ed47b4a0198313377e091bb3957bbbc63d937805426d1b2b6de39d0a50d32a0cR1870
ryoqun
approved these changes
May 28, 2021
Contributor
ryoqun
left a comment
ryoqun
left a comment
There was a problem hiding this comment.
LGTM! Thanks for cleaning. :)
mergify Bot
pushed a commit
that referenced
this pull request
Jun 2, 2021
(cherry picked from commit 1d02dba)
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Remove unnecessary code. Unless I'm missing something.
Summary of Changes
Fixes #