Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

cli: Add --seed support to deactivate-stake and withdraw-stake commands#16712

Merged
mergify[bot] merged 2 commits intosolana-labs:masterfrom
mvines:se
Apr 21, 2021
Merged

cli: Add --seed support to deactivate-stake and withdraw-stake commands#16712
mergify[bot] merged 2 commits intosolana-labs:masterfrom
mvines:se

Conversation

@mvines
Copy link
Copy Markdown
Contributor

@mvines mvines commented Apr 21, 2021

I was performing some testnet staking maneuvers earlier today and my plan was to use solana split-stake --seed to easily carve out some stake, then deactivate and withdraw it. But deactivate-stake and withdraw-stake don't support --seed.

I could have used solana create-address-with-seed to figure the derived account address but that's an unnatural workaround.

@mvines mvines added the v1.6 label Apr 21, 2021
@mvines
Copy link
Copy Markdown
Contributor Author

mvines commented Apr 21, 2021

cluster_info::tests::test_pull_request_time_pruning failed, mashing retry

@mvines
Copy link
Copy Markdown
Contributor Author

mvines commented Apr 21, 2021

cluster_info::tests::test_pull_request_time_pruning failed, mashing retry

failed again

@mvines
Copy link
Copy Markdown
Contributor Author

mvines commented Apr 21, 2021

cc: #16713

@mvines mvines added the automerge Merge this Pull Request automatically once CI passes label Apr 21, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2021

Codecov Report

Merging #16712 (303e832) into master (0924c2d) will increase coverage by 0.0%.
The diff coverage is 99.1%.

@@           Coverage Diff           @@
##           master   #16712   +/-   ##
=======================================
  Coverage    82.9%    83.0%           
=======================================
  Files         416      416           
  Lines      115439   115494   +55     
=======================================
+ Hits        95784    95872   +88     
+ Misses      19655    19622   -33     

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

automerge Merge this Pull Request automatically once CI passes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant