This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Don't stop to find newer cluster-confirmed roots#14557
Merged
mergify[bot] merged 3 commits intosolana-labs:masterfrom Jan 13, 2021
Merged
Don't stop to find newer cluster-confirmed roots#14557mergify[bot] merged 3 commits intosolana-labs:masterfrom
mergify[bot] merged 3 commits intosolana-labs:masterfrom
Conversation
Contributor
Author
|
oh test failed; nice! |
Contributor
Author
|
This pr is vouched from @carllin via dm. I'm going to merge this as this is very nasty one and considering this is effectively one line change. |
Contributor
Author
|
test result: BEFORE |
Contributor
Author
|
AFTER |
Contributor
Author
|
this is working as expected. |
Codecov Report
@@ Coverage Diff @@
## master #14557 +/- ##
=======================================
Coverage 80.4% 80.4%
=======================================
Files 402 402
Lines 100897 100919 +22
=======================================
+ Hits 81149 81190 +41
+ Misses 19748 19729 -19 |
Contributor
|
That's a great find. I was thinking we needed accounts background service running while doing blockstore processor. |
mergify Bot
pushed a commit
that referenced
this pull request
Jan 13, 2021
* Don't stop to find newer cluster-confirmed roots * Fix and add new tests * nits (cherry picked from commit e95ebcf) # Conflicts: # ledger/src/blockstore_processor.rs
mergify Bot
pushed a commit
that referenced
this pull request
Jan 13, 2021
* Don't stop to find newer cluster-confirmed roots * Fix and add new tests * nits (cherry picked from commit e95ebcf)
Contributor
|
@ryoqun thanks for the fix! |
mergify Bot
added a commit
that referenced
this pull request
Jan 14, 2021
* Don't stop to find newer cluster-confirmed roots (#14557) * Don't stop to find newer cluster-confirmed roots * Fix and add new tests * nits (cherry picked from commit e95ebcf) # Conflicts: # ledger/src/blockstore_processor.rs * My blind merge conflict edit! * blind 2 Co-authored-by: Ryo Onodera <ryoqun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ledger processing are too prone to OOM with
--no-snapshot-fetch.Well, sadly, detection of cluster-confirmed root is done only once..... So, after that, it'll soon no
exhaustively_free_unused_resource(), grow accounts db many banks and no squash because of no roots and killing validator via OOM and looping over and over. This confuses some partners very seriously:This also means this also causes validator resumes with very unoptimized way because cleaning is stopped at latter part of blockstore_processor.
Summary of Changes
I'll add a test soon.(ADDED d8a7c5a)
Fixes #