Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERC20-like Token program (v0.9) #1451

Merged
merged 3 commits into from
Oct 9, 2018
Merged

Add ERC20-like Token program (v0.9) #1451

merged 3 commits into from
Oct 9, 2018

Conversation

mvines
Copy link
Member

@mvines mvines commented Oct 9, 2018

See #1343

This PR currently has 0 tests (which is why it's marked WIP). Will fill those in next, but I wanted to share for some initial review.

However the SDK side of this is solana-labs/solana-web3.js#19 with a fair number of tests that all pass with this PR running.

Note: this is going into v0.9 first because that's what the SDK currently runs against. Will merge to master as a second step.

@mvines mvines added the work in progress This isn't quite right yet label Oct 9, 2018
@mvines mvines requested a review from garious October 9, 2018 04:28
@mvines
Copy link
Member Author

mvines commented Oct 9, 2018

@garious - can you please take a first pass at this. My goal here is to support the identical feature set as ERC20 (expressed in a slightly different way) and not a bit more.

token-program.js on the SDK side might help with some context too.

@mvines mvines force-pushed the v0.9 branch 2 times, most recently from f3a779e to a595c2d Compare October 9, 2018 04:38
@garious
Copy link
Contributor

garious commented Oct 9, 2018

Yep, that looks good to me. Will the next step (after this PR is merged) be to make it linkable?

@mvines
Copy link
Member Author

mvines commented Oct 9, 2018

Maybe, what do you mean by linkable?

@garious
Copy link
Contributor

garious commented Oct 9, 2018

To compile this to a bytecode (like BPF or Wasm) and submit it to the chain from a transaction. Or are you thinking we just statically link this one as-is and start advertising support for spinning up erc20-like tokens on the solana testnet?

@mvines
Copy link
Member Author

mvines commented Oct 9, 2018

Or are you thinking we just statically link this one as-is and start advertising support for spinning up erc20-like tokens on the solana testnet?

Yeah, this for now. Then once the SDK program submission is built out, the program gets rewritten and probably moves directly into the SDK repository.

@mvines mvines force-pushed the v0.9 branch 2 times, most recently from 2edbcf2 to 8b54403 Compare October 9, 2018 17:28
@mvines mvines removed the work in progress This isn't quite right yet label Oct 9, 2018
@garious
Copy link
Contributor

garious commented Oct 9, 2018

Got a Pillbox ticket to track adding this to master?

@mvines
Copy link
Member Author

mvines commented Oct 9, 2018

Yeah, referenced right at the top of the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants