-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ERC20-like Token program (v0.9) #1451
Conversation
@garious - can you please take a first pass at this. My goal here is to support the identical feature set as ERC20 (expressed in a slightly different way) and not a bit more. token-program.js on the SDK side might help with some context too. |
f3a779e
to
a595c2d
Compare
Yep, that looks good to me. Will the next step (after this PR is merged) be to make it linkable? |
Maybe, what do you mean by linkable? |
To compile this to a bytecode (like BPF or Wasm) and submit it to the chain from a transaction. Or are you thinking we just statically link this one as-is and start advertising support for spinning up erc20-like tokens on the solana testnet? |
Yeah, this for now. Then once the SDK program submission is built out, the program gets rewritten and probably moves directly into the SDK repository. |
2edbcf2
to
8b54403
Compare
Got a Pillbox ticket to track adding this to master? |
Yeah, referenced right at the top of the PR |
See #1343
This PR currently has 0 tests (which is why it's marked WIP). Will fill those in next, but I wanted to share for some initial review.
However the SDK side of this is solana-labs/solana-web3.js#19 with a fair number of tests that all pass with this PR running.
Note: this is going into v0.9 first because that's what the SDK currently runs against. Will merge to
master
as a second step.