This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Re-use accounts stores (#12885)#14185
Closed
sakridge wants to merge 1 commit intosolana-labs:v1.4from
Closed
Conversation
* Re-use accounts_db stores Creating files and dropping mmap areas can be expensive * Add test for storage finder Can encounter an infinite loop when the store is too small, but smaller than the normal store size. * Fix storage finding * Check for strong_count == 1 * try_recycle helper
Codecov Report
@@ Coverage Diff @@
## v1.4 #14185 +/- ##
=======================================
Coverage 82.2% 82.3%
=======================================
Files 382 382
Lines 94303 94532 +229
=======================================
+ Hits 77574 77802 +228
- Misses 16729 16730 +1 |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
stale
Bot
added
the
stale
|
This stale pull request has been automatically closed. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Creating files and dropping mmap areas can be expensive
Summary of Changes
Re-use accounts_db stores
Add test for storage finder
Can encounter an infinite loop when the store is too small, but
smaller than the normal store size.
Fix storage finding
Check for strong_count == 1
try_recycle helper
backport of #12885
Fixes #