This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Enhance ledger-tool for multi-epoch rewards#13837
Merged
mergify[bot] merged 3 commits intosolana-labs:masterfrom Nov 27, 2020
Merged
Enhance ledger-tool for multi-epoch rewards#13837mergify[bot] merged 3 commits intosolana-labs:masterfrom
mergify[bot] merged 3 commits intosolana-labs:masterfrom
Conversation
ryoqun
added
automerge
Contributor
Author
I'm also backporting this into v1.3 just in case. |
2 tasks
ryoqun
changed the title
Codecov Report
@@ Coverage Diff @@
## master #13837 +/- ##
=======================================
Coverage 82.0% 82.0%
=======================================
Files 381 381
Lines 93217 93220 +3
=======================================
+ Hits 76522 76531 +9
+ Misses 16695 16689 -6 |
mergify Bot
pushed a commit
that referenced
this pull request
Nov 27, 2020
* Support ledger-tool for multi-epoch rewards * nits * Ensure not to skip some records in csv (cherry picked from commit 6048342) # Conflicts: # ledger-tool/src/main.rs
mergify Bot
pushed a commit
that referenced
this pull request
Nov 27, 2020
* Support ledger-tool for multi-epoch rewards * nits * Ensure not to skip some records in csv (cherry picked from commit 6048342)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#13680 succeeded to retain ability for multi-epoch rewards for nano stake accounts, which was planned to be killed by #13233 .
And
ledger-tool caphasn't been prepared for it it beause I was planning to merge #13233.Summary of Changes
So, support multi-epoch rewards correctly and bunch of other niceties:
--enable-stake-v2handle more in-transistion ledger state. (we have now two relevant feature flags)I'm pretty sure there is no functional change to core implementation; so I'm bypassing review to ease fixing more important bug (#13836).
Fixes #