This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Discard pre hard fork persisted tower if hard-forking#13536
Merged
ryoqun merged 5 commits intosolana-labs:masterfrom Nov 12, 2020
Merged
Discard pre hard fork persisted tower if hard-forking#13536ryoqun merged 5 commits intosolana-labs:masterfrom
ryoqun merged 5 commits intosolana-labs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #13536 +/- ##
=========================================
- Coverage 82.1% 82.1% -0.1%
=========================================
Files 378 378
Lines 90603 90627 +24
=========================================
+ Hits 74435 74439 +4
- Misses 16168 16188 +20 |
ryoqun
approved these changes
Nov 12, 2020
Contributor
ryoqun
left a comment
ryoqun
left a comment
There was a problem hiding this comment.
LGTM! thanks for cleaning!
mergify Bot
pushed a commit
that referenced
this pull request
Nov 12, 2020
* Discard pre hard fork persisted tower if hard-forking * Relax config.require_tower * Add cluster test * nits * Remove unnecessary check Co-authored-by: Ryo Onodera <ryoqun@gmail.com> Co-authored-by: Carl Lin <carl@solana.com> (cherry picked from commit 9821a77)
2 tasks
mergify Bot
added a commit
that referenced
this pull request
Nov 12, 2020
* Discard pre hard fork persisted tower if hard-forking * Relax config.require_tower * Add cluster test * nits * Remove unnecessary check Co-authored-by: Ryo Onodera <ryoqun@gmail.com> Co-authored-by: Carl Lin <carl@solana.com> (cherry picked from commit 9821a77) Co-authored-by: carllin <wumu727@gmail.com>
CriesofCarrots
pushed a commit
to CriesofCarrots/solana
that referenced
this pull request
Dec 4, 2020
CriesofCarrots
pushed a commit
to CriesofCarrots/solana
that referenced
this pull request
Dec 4, 2020
CriesofCarrots
pushed a commit
to CriesofCarrots/solana
that referenced
this pull request
Dec 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Taking over: #13527
Summary of Changes
Nits and commented out seemingly unnecessary check: https://github.com/solana-labs/solana/pull/13527/files#r521663621
Fixes #