This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Clean up Delegation::stake_activating_and_deactivating#13471
Merged
ryoqun merged 1 commit intosolana-labs:masterfrom Nov 9, 2020
Merged
Clean up Delegation::stake_activating_and_deactivating#13471ryoqun merged 1 commit intosolana-labs:masterfrom
ryoqun merged 1 commit intosolana-labs:masterfrom
Conversation
Contributor
Author
Codecov Report
@@ Coverage Diff @@
## master #13471 +/- ##
=========================================
- Coverage 82.1% 82.1% -0.1%
=========================================
Files 378 378
Lines 90402 90411 +9
=========================================
- Hits 74244 74239 -5
- Misses 16158 16172 +14 |
mvines
approved these changes
Nov 9, 2020
Contributor
Author
|
odd
Well, I'll merge this pr anyway, the buildkite says ok to do so. :) FYI: @mvines |
mergify Bot
pushed a commit
that referenced
this pull request
Nov 9, 2020
(cherry picked from commit 5306eb9)
mergify Bot
pushed a commit
that referenced
this pull request
Nov 9, 2020
(cherry picked from commit 5306eb9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
stake_activating_and_deactivating is a bit hard to read.
Summary of Changes
Make it more readable. As I said before, this is also blocking pr for stake calculation bug (I'm now writing a pr).
There should be no functional change.
This is a follow-up to: #13460