Show more detailed vote history in shorter format#13374
Show more detailed vote history in shorter format#13374ryoqun merged 3 commits intosolana-labs:masterfrom
Conversation
| writeln!( | ||
| f, | ||
| " credits range: [{}..{})", | ||
| entry.prev_credits, entry.credits |
There was a problem hiding this comment.
Especially, I needed this info.
| writeln!( | ||
| f, | ||
| " credits/slots: {}/{}", | ||
| entry.credits_earned, entry.slots_in_epoch |
There was a problem hiding this comment.
Imply that credits here cannot be larger than slots. Also removed extra adjectives because the context should clarify them.
| writeln!(f, "- slot: {}", vote.slot)?; | ||
| writeln!(f, " confirmation count: {}", vote.confirmation_count)?; | ||
| } | ||
| writeln!(f, "Epoch Voting History (without skipped slots):")?; |
There was a problem hiding this comment.
Actually, I wanted to show skipped slots but it's not easy task. So, at least show a note about it to educate/inform users correctly.
There was a problem hiding this comment.
tried to be shorter but this might be too ambuguious. (skipped slots not considered)/(missed credits can be skipped slots) might be better?
There was a problem hiding this comment.
I do find that language a little confusing.
Maybe something like this on a new line? * not all epoch slots may have been available to vote on
There was a problem hiding this comment.
@CriesofCarrots Thanks for suggestion! I've further adjusted the wording based on yours to make interested users be able to have a clue to know more: 14bdcba How does this look?
There was a problem hiding this comment.
Much better. Thanks for the polish!
Codecov Report
@@ Coverage Diff @@
## master #13374 +/- ##
=======================================
Coverage 82.0% 82.0%
=======================================
Files 376 376
Lines 87888 87901 +13
=======================================
+ Hits 72107 72120 +13
Misses 15781 15781 |
2 participants
Problem
Sometimes we want to view human-friendly raw data of vote accounts. But,
solana vote-accountis too kind to show that level of detailed information. It only shows some computed information.Summary of Changes
Show everything, also tidy up formatting a bit, inspired by
solana epoch-info.before
after
Context #13233