This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Use pico inflation for ledger-tool capitalization --enable-inflation#13215
Merged
ryoqun merged 2 commits intosolana-labs:masterfrom Oct 28, 2020
Merged
Use pico inflation for ledger-tool capitalization --enable-inflation#13215ryoqun merged 2 commits intosolana-labs:masterfrom
ryoqun merged 2 commits intosolana-labs:masterfrom
Conversation
mvines
previously approved these changes
Oct 28, 2020
Contributor
mvines
left a comment
mvines
left a comment
There was a problem hiding this comment.
Yes I don't see a problem with this "breaking" change
Contributor
Author
|
@ericlwilliams FYI, this is a simulation for pico inflation with mainnet-beta's stake accounts and credits if enabled. this doesn't consider any rent/fee distribution, though. This is the balance changes what distribution of inflation rewards at the first slot in the next epoch with validator's current performance. This is formatted differently from I add this functionality mainly for cheeking implementation. As far as I'm looking the results. It seem that there is no odd things at the moment. |
Contributor
Author
|
Well, this is certainly an odd outlier:
uuum. I'm investigating now. |
Contributor
Author
But, there is inflation rewards? This looks very odd. |
Codecov Report
@@ Coverage Diff @@
## master #13215 +/- ##
=======================================
Coverage 82.1% 82.2%
=======================================
Files 375 375
Lines 86811 86814 +3
=======================================
+ Hits 71350 71369 +19
+ Misses 15461 15445 -16 |
ryoqun
added a commit
that referenced
this pull request
Oct 28, 2020
Contributor
addressed: #13233 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ledger-toolisn't using pico inflation.Summary of Changes
Use it.
This is incompatible change but I think it's ok to break compat for
ledger-tool, right?