This repository was archived by the owner on Jan 22, 2025. It is now read-only.
cargo-build-bpf: Remove legacy program feature support#13094
Closed
mvines wants to merge 1 commit intosolana-labs:masterfrom
Closed
cargo-build-bpf: Remove legacy program feature support#13094mvines wants to merge 1 commit intosolana-labs:masterfrom
mvines wants to merge 1 commit intosolana-labs:masterfrom
Conversation
Contributor
Author
|
Expected to fail until #12989 lands |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once #12989 lands,
cargo-build-bpfcan drop support for the detection of non-ported program crates that require--no-default-features --features program. This was added just as temporary convenience and it's reasonable to require thatcargo-build-bpfusers use the new style of depending onsolana-program-sdkinstead ofsolana-sdk