This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Add cargo-build-bpf#13040
Merged
mvines merged 2 commits intosolana-labs:masterfrom Oct 22, 2020
Merged
Conversation
7627252 to
600050d
Compare
Contributor
Author
|
Welp looks like I need to rewrite |
Contributor
Author
|
Neat, I cherry-picked this PR on top of #12989 and it works! |
bf9ab9b to
f67f8e5
Compare
Contributor
Author
|
Rewrote Now wander over to SPL land: It's smart enough to know when it's not building a cdylib too: and trying to build something silly produces a reasonable error output: |
Contributor
|
Looking good, nice to see the build scripts tucked under a cargo subcommand |
Contributor
Author
|
This is pretty much ready to land, latest commit deletes |
Codecov Report
@@ Coverage Diff @@
## master #13040 +/- ##
=========================================
- Coverage 82.1% 82.1% -0.1%
=========================================
Files 366 366
Lines 86237 86237
=========================================
- Hits 70878 70869 -9
- Misses 15359 15368 +9 |
Contributor
Author
|
ooo, green CI. Now's my chance! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo-build-bpfis a less opinionated version ofsdk/bpf/rust/build.sh. It:--no-default-features --features programon youcargo build-bpf ...solana-install ..so it just works once you get the solana cli installedExample: build parts of the tree for BPF:
(note: once
program-sdk/exists (#12989), these extra args disappear)TODO
do.shdoes--dumpflag to obsoletedo.sh dump ...