This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Follow up to persistent tower with tests and API cleaning (bp #12350)#12972
Merged
mergify[bot] merged 1 commit intov1.4from Oct 19, 2020
Merged
Follow up to persistent tower with tests and API cleaning (bp #12350)#12972mergify[bot] merged 1 commit intov1.4from
mergify[bot] merged 1 commit intov1.4from
Conversation
* Follow up to persistent tower * Ignore for now... * Hard-code validator identities for easy reasoning * Add a test for opt. conf violation without tower * Fix compile with rust < 1.47 * Remove unused method * More move of assert tweak to the asser pr * Add comments * Clean up * Clean the test addressing various review comments * Clean up a bit (cherry picked from commit 54517ea)
mergify
Bot
added
the
automerge
Codecov Report
@@ Coverage Diff @@
## v1.4 #12972 +/- ##
========================================
- Coverage 81.9% 81.9% -0.1%
========================================
Files 361 361
Lines 85097 85112 +15
========================================
+ Hits 69729 69733 +4
- Misses 15368 15379 +11 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated backport of pull request #12350 done by Mergify
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/