This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Another some tower logging improvements#12940
Merged
ryoqun merged 1 commit intosolana-labs:masterfrom Oct 16, 2020
Merged
Conversation
ryoqun
added
automerge
Contributor
|
automerge label removed due to a CI failure |
mergify
Bot
removed
the
automerge
Codecov Report
@@ Coverage Diff @@
## master #12940 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 362 362
Lines 85212 85215 +3
=========================================
- Hits 69855 69847 -8
- Misses 15357 15368 +11 |
ryoqun
removed
the
automerge
mergify Bot
pushed a commit
that referenced
this pull request
Oct 16, 2020
(cherry picked from commit fd8ec27)
CriesofCarrots
pushed a commit
to CriesofCarrots/solana
that referenced
this pull request
Dec 4, 2020
CriesofCarrots
pushed a commit
to CriesofCarrots/solana
that referenced
this pull request
Dec 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Some tower assertions is unhelpful when debugging.
Summary of Changes
Fix that.
automerge-ing this because this is really small improvement.absolutely, there is no functional change. :)
follow up #12875
related to #12671
cc: @carllin