bank: Don't bother paying 0 rent#12791
Conversation
mvines
added
v1.3
automerge
Codecov Report
@@ Coverage Diff @@
## master #12791 +/- ##
=======================================
Coverage 81.9% 81.9%
=======================================
Files 360 360
Lines 84776 84778 +2
=======================================
+ Hits 69461 69465 +4
+ Misses 15315 15313 -2 |
| post_balance: account.lamports, | ||
| }, | ||
| )); | ||
| if rent_to_be_paid > 0 { |
There was a problem hiding this comment.
I mean, this ultimately produces different bank hashes.
There was a problem hiding this comment.
Oh really? Wow. Because self.store_account(&pubkey, &account); was skipped here? My main goal was to skip rewards.push(...), but then didn't see a reason to not skip the entire block and no test told me otherwise!
Mainnet-beta should be fine since rent is still 100% burned. There's been rent payments on testnet though since this PR is in 1.3.16, testnet hasn't blown apart yet. Have we just been lucky?
There was a problem hiding this comment.
Oh my bad. This PR missed v1.3.16 so it's not live on testnet/mainnet-beta yet 😅
There was a problem hiding this comment.
Because
self.store_account(&pubkey, &account);was skipped here?
Yeah, I think so. Just preparing to test this locally as well.
Oh my bad. This PR missed v1.3.16 so it's not live on testnet/mainnet-beta yet sweat_smile
😅
2 participants
No description provided.