This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Move process_instruction defs to runtime#12507
Merged
jackcmay merged 4 commits intosolana-labs:masterfrom Sep 29, 2020
Merged
Conversation
mvines
reviewed
Sep 25, 2020
| @@ -7,10 +7,12 @@ extern crate solana_exchange_program; | |||
| #[macro_use] | |||
| extern crate solana_vest_program; | |||
|
|
|||
Contributor
There was a problem hiding this comment.
Can you rebase on #12490 (review for that PR would be great too!). genesis-programs/... is no more!
c3e770c to
f7d89d1
Compare
f7d89d1 to
3fcf642
Compare
Contributor
Author
|
@ryoqun Any ideas on how to fix this CI? Background, I moved types from the sdk into runtime. The bank depends on |
jackcmay
commented
Sep 29, 2020
| ) -> Result<(), InstructionError>; | ||
| } | ||
| #[cfg(RUSTC_WITH_SPECIALIZATION)] | ||
| impl AbiExample for Arc<dyn Executor> { |
Contributor
Author
There was a problem hiding this comment.
@ryoqun Here is the code that breaks:
error[E0117]: only traits defined in the current crate can be implemented for arbitrary types
--> runtime/src/process_instruction.rs:134:1
|
134 | impl AbiExample for Arc<dyn Executor> {
| ^^^^^^^^^^^^^^^^^^^^-----------------
| | |
| | `Arc` is not defined in the current crate
| impl doesn't use only types from inside the current crate
|
= note: define and implement a trait or new type instead
error: aborting due to previous error; 1 warning emitted
Contributor
Author
|
@ryoqun Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #12507 +/- ##
=========================================
- Coverage 82.0% 82.0% -0.1%
=========================================
Files 354 354
Lines 82643 82636 -7
=========================================
- Hits 67788 67780 -8
- Misses 14855 14856 +1 |
mergify Bot
pushed a commit
that referenced
this pull request
Sep 29, 2020
(cherry picked from commit 2ff9836)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
FeatureSetintoInvokeContextbutFeatureSetis local to runtimeSummary of Changes
These definitions don't need to be in the SDK and moving them into runtime brings them in with their users and allows us to leave
FeatureSetwhere it is.Fixes #