This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Ledger replay supermajority squash doesn't handle duplicate roots#12319
Merged
carllin merged 1 commit intosolana-labs:masterfrom Sep 18, 2020
Merged
Ledger replay supermajority squash doesn't handle duplicate roots#12319carllin merged 1 commit intosolana-labs:masterfrom
carllin merged 1 commit intosolana-labs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12319 +/- ##
=======================================
Coverage 82.1% 82.1%
=======================================
Files 342 342
Lines 80393 80433 +40
=======================================
+ Hits 66030 66097 +67
+ Misses 14363 14336 -27 |
ryoqun
approved these changes
Sep 18, 2020
Contributor
ryoqun
left a comment
ryoqun
left a comment
There was a problem hiding this comment.
LGTM! Thanks for fixing this quickly!
mergify Bot
pushed a commit
that referenced
this pull request
Sep 18, 2020
(cherry picked from commit 3533e11)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Detection of supermajority root on ledger replay does not sum the stake of vote accounts with the same root. Thanks @ryoqun for pointing this out: #11727 (comment)
Summary of Changes
Fix and add test
Fixes #