This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Use conventional special self notation#11990
Merged
mergify[bot] merged 1 commit intosolana-labs:masterfrom Sep 2, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11990 +/- ##
=========================================
- Coverage 82.2% 82.2% -0.1%
=========================================
Files 333 333
Lines 78222 78222
=========================================
- Hits 64328 64309 -19
- Misses 13894 13913 +19 |
mergify Bot
pushed a commit
that referenced
this pull request
Sep 2, 2020
(cherry picked from commit 46aac48)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Well, when I moved this from
MessageProcessorat #11750, this bad practice began. And quickly got widespread. ;)