This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Clarify comments and names in inflation code#11977
Merged
ryoqun merged 1 commit intosolana-labs:masterfrom Sep 3, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11977 +/- ##
=======================================
Coverage 82.1% 82.2%
=======================================
Files 333 333
Lines 78153 78223 +70
=======================================
+ Hits 64236 64330 +94
+ Misses 13917 13893 -24 |
Contributor
Author
|
@t-nelson Could you sanity-check this? :) |
mergify Bot
pushed a commit
that referenced
this pull request
Sep 3, 2020
(cherry picked from commit 89bca61)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
There is somewhat outdated/wrong comment and misleading identifier names for the inflation code.
Also, we could add a sanity assertion for
yearbeing>= 0.Summary of Changes
Do them.
There should be no function change.
Context
folllow-up #10914