This repository was archived by the owner on Jan 22, 2025. It is now read-only.
genesis-programs: Simplify get_programs(), specify a real Preview activation epoch for new BPFLoader#11916
Merged
mergify[bot] merged 1 commit intosolana-labs:masterfrom Aug 31, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11916 +/- ##
=========================================
- Coverage 82.1% 82.1% -0.1%
=========================================
Files 331 331
Lines 78062 78059 -3
=========================================
- Hits 64166 64155 -11
- Misses 13896 13904 +8 |
ryoqun
reviewed
Aug 31, 2020
ryoqun
reviewed
Aug 31, 2020
| ), | ||
| (Program::BuiltinLoader(solana_bpf_loader_program!()), 89), | ||
| ], | ||
| OperatingMode::Stable => { |
Contributor
There was a problem hiding this comment.
nits: we can strip { and } just like OperatingMode::Preview.
ryoqun
reviewed
Aug 31, 2020
| *callback_w = Some(entered_epoch_callback); | ||
| } | ||
| // immedaitely fire the callback as initial invocation | ||
| // immediately fire the callback as initial invocation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vec![]declaration for each operation mode. The use of.extend()seemed overly verbose