This repository was archived by the owner on Jan 22, 2025. It is now read-only.
ledger-tool: modify-genesis command now writes elsewhere and produces a full genesis.tar.bz2#11899
Merged
mvines merged 2 commits intosolana-labs:masterfrom Aug 29, 2020
Merged
ledger-tool: modify-genesis command now writes elsewhere and produces a full genesis.tar.bz2#11899mvines merged 2 commits intosolana-labs:masterfrom
mvines merged 2 commits intosolana-labs:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11899 +/- ##
=========================================
+ Coverage 82.0% 82.1% +0.1%
=========================================
Files 330 331 +1
Lines 77588 78054 +466
=========================================
+ Hits 63688 64151 +463
- Misses 13900 13903 +3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just producing a genesis.bin is not enough, we need the full tar.bz2. Also overwriting the old genesis is poor form.