This repository was archived by the owner on Jan 22, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
explorer: Auto-update transactions until they reach max confirmation #11841
Merged
oJshua
merged 18 commits into
solana-labs:master
from
oJshua:feature/11760-auto-update-transactions-until-max
Aug 28, 2020
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
7b299ca
explorer: Auto-update transactions until they reach max confirmation
oJshua 2ede5a6
convert to side effect
oJshua 0d8cdcf
proper cleanup
oJshua 5056b47
minor cleanup
oJshua 400b1a8
pull isAutoRefresh from context, refactor, and add loading indicator …
oJshua e3feb7d
split effects into two, manage interval in one effect only
oJshua 15d287e
simplify interval
oJshua 2ff4fe3
move autoRefresh up a level, use computed value
oJshua 0eb875b
flip conditional for readability
oJshua 824b0d6
accidentally factored out not found case
oJshua 35a2558
add attempts bailout
oJshua ce52794
run prettier
oJshua db27f14
bailout after 5 polls of 0 confirmations
oJshua 42d07b2
move bailout into state, change autoRefresh prop to enum to support b…
oJshua 3e6277e
run prettier to clean up formatting
oJshua 741fcfa
reintroduce details not available until max confirmations message
oJshua 0d3cf7a
add error card with refresh if zero confirmation bailout
oJshua 29cf867
allow retry on bailouts
oJshua File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think it would be nice to show this error card when auto refresh has been bailed out, thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree! I added that case. If it doesn't make sense to have a retry button I can pull that out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retry makes sense! But it should be
refreshStatusbecause otherwise the details could get refreshed but the status would be still stuck showing 0 confirmationsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yes, done!