explorer: Auto-update transactions until they reach max confirmation#11747
explorer: Auto-update transactions until they reach max confirmation#11747oJshua wants to merge 28 commits intosolana-labs:masterfrom
Conversation
|
The ticket has a screenshot of this section in row form:
I worked on the TransactionsDetails page. Is this screenshot from the tokens section? |
jstarry
left a comment
jstarry
left a comment
There was a problem hiding this comment.
It works! I think we should add a couple things to make it more user-friendly
- loading indicator to indicate auto refreshing
- disable / hide refresh button when auto refreshing
I also noticed that the details section (getConfirmedTransaction) gets loaded twice for some reason. Could you look into why that's happening?
|
This iteration is much cleaner. Let me know what you think about the loading indicator in the top right of the component. |
oJshua
force-pushed
the
feature/65-autorefresh-transaction-until-max
branch
from
592652b to
6f90799
Compare
| ...entry, | ||
| status: action.status, | ||
| data: reconciler(entry?.data, action.data), | ||
| attempts: |
There was a problem hiding this comment.
Confirmation attempts feels too specific to transactions to be added here. In the future, something like a retry counter for failed fetches would be nice here though
There was a problem hiding this comment.
Attempts in this case is just the number of successful fetches completed, not so much the number of confirmation attempts. Maybe attempts is the wrong name. Should this go elsewhere?
oJshua
force-pushed
the
feature/65-autorefresh-transaction-until-max
branch
from
685ef9c to
73b2359
Compare
….com:oJshua/solana into feature/65-autorefresh-transaction-until-max
|
Closing because I had an unclean commit history |
|
@oJshua feel free to force push next time! |
2 participants
Problem
When a transaction that hasn't reached max confirmations is entered, the user needs to mash the refresh button on the right until it reaches max confirmation.
Summary of Changes
Status card auto-refreshes every 2 seconds until the confirmation max is reached. Account card will display loading card while auto-refresh is in process. A loading indicator is placed in the top right. Once full confirmation is complete, the refresh button becomes available.
Fixes #11760