Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Cleanup test utilities #11723

Merged
mergify[bot] merged 2 commits intosolana-labs:masterfrom
carllin:FixMetrics
Aug 20, 2020
Merged

Cleanup test utilities #11723
mergify[bot] merged 2 commits intosolana-labs:masterfrom
carllin:FixMetrics

Conversation

@carllin
Copy link
Copy Markdown
Contributor

@carllin carllin commented Aug 20, 2020

Problem

  1. blockstore::add_tree() does not make replayable/verifiable slots for tests
  2. ValidatorVoteKeypair is inconsistent with 1.2, making backports ugly

Summary of Changes

Resolve above

Fixes #

@carllin carllin added the automerge Merge this Pull Request automatically once CI passes label Aug 20, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 20, 2020

Codecov Report

Merging #11723 into master will decrease coverage by 0.0%.
The diff coverage is 87.7%.

@@            Coverage Diff            @@
##           master   #11723     +/-   ##
=========================================
- Coverage    82.0%    82.0%   -0.1%     
=========================================
  Files         330      330             
  Lines       76733    76742      +9     
=========================================
- Hits        62972    62955     -17     
- Misses      13761    13787     +26     

@mergify mergify Bot merged commit b7ed06b into solana-labs:master Aug 20, 2020
This was referenced Aug 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

automerge Merge this Pull Request automatically once CI passes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant