Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Assume signature verification filters bad packets#116

Closed
garious wants to merge 1 commit intosolana-labs:masterfrom
garious:filter-spam
Closed

Assume signature verification filters bad packets#116
garious wants to merge 1 commit intosolana-labs:masterfrom
garious:filter-spam

Conversation

@garious
Copy link
Copy Markdown
Contributor

@garious garious commented Apr 11, 2018

Commented out signature verification and no tests failed. :(

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #116 into master will increase coverage by 0.31%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #116      +/-   ##
========================================
+ Coverage   95.68%    96%   +0.31%     
========================================
  Files          17     17              
  Lines        1508   1502       -6     
========================================
- Hits         1443   1442       -1     
+ Misses         65     60       -5
Impacted Files Coverage Δ
src/accountant_skel.rs 95.23% <100%> (+1.55%) ⬆️
src/historian.rs 98.36% <0%> (-1.64%) ⬇️
src/packet.rs 95.41% <0%> (+1.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 078179e...96e7378. Read the comment docs.

Comment thread src/accountant_skel.rs
batch.into_iter().zip(r).collect()
let _r = ecdsa::ed25519_verify(&batch);
//batch.into_iter().zip(r).collect();
batch
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how is this going to work without a bunch of memcopy or reallocation?

@garious garious closed this Apr 11, 2018
vkomenda referenced this pull request in vkomenda/solana Aug 29, 2021
Bumps [webpack-cli](https://github.com/webpack/webpack-cli) from 3.3.11 to 3.3.12.
- [Release notes](https://github.com/webpack/webpack-cli/releases)
- [Changelog](https://github.com/webpack/webpack-cli/blob/v3.3.12/CHANGELOG.md)
- [Commits](webpack/webpack-cli@v3.3.11...v3.3.12)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
segfaultdoc added a commit to jito-labs/solana that referenced this pull request Aug 7, 2024
Co-authored-by: Jed <4679729+jedleggett@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants