Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Fix bad rent in Bank::deposit as if since epoch 0 (bp #10468)#11539

Merged
mergify[bot] merged 1 commit intov1.3from
mergify/bp/v1.3/pr-10468
Aug 11, 2020
Merged

Fix bad rent in Bank::deposit as if since epoch 0 (bp #10468)#11539
mergify[bot] merged 1 commit intov1.3from
mergify/bp/v1.3/pr-10468

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented Aug 11, 2020

This is an automated backport of pull request #10468 done by Mergify

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the simulator.

Finally, you can contact us on https://mergify.io/

* Fix bad rent in Bank::deposit as if since epoch 0

* Remove redundant predicate

* Rename

* Start to add tests with some cleanup

* Forgot to add refactor code...

* Enchance test

* Really fix rent timing in deposit with robust test

* Simplify new behavior by disabling rent altogether

(cherry picked from commit 6c242f3)
@mergify mergify Bot added the automerge Merge this Pull Request automatically once CI passes label Aug 11, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 11, 2020

Codecov Report

Merging #11539 into v1.3 will increase coverage by 0.0%.
The diff coverage is 92.4%.

@@          Coverage Diff           @@
##            v1.3   #11539   +/-   ##
======================================
  Coverage   81.9%    81.9%           
======================================
  Files        324      324           
  Lines      75818    75870   +52     
======================================
+ Hits       62119    62182   +63     
+ Misses     13699    13688   -11     

@mergify mergify Bot merged commit 53e917b into v1.3 Aug 11, 2020
@mergify mergify Bot deleted the mergify/bp/v1.3/pr-10468 branch August 11, 2020 16:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

automerge Merge this Pull Request automatically once CI passes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant