This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Fix bad rent in Bank::deposit as if since epoch 0 (bp #10468)#11538
Merged
mergify[bot] merged 3 commits intov1.2from Aug 11, 2020
Merged
Fix bad rent in Bank::deposit as if since epoch 0 (bp #10468)#11538mergify[bot] merged 3 commits intov1.2from
mergify[bot] merged 3 commits intov1.2from
Conversation
* Fix bad rent in Bank::deposit as if since epoch 0 * Remove redundant predicate * Rename * Start to add tests with some cleanup * Forgot to add refactor code... * Enchance test * Really fix rent timing in deposit with robust test * Simplify new behavior by disabling rent altogether (cherry picked from commit 6c242f3) # Conflicts: # runtime/src/accounts.rs # runtime/src/rent_collector.rs
Contributor
Author
|
automerge label removed due to a CI failure |
Codecov Report
@@ Coverage Diff @@
## v1.2 #11538 +/- ##
======================================
Coverage 81.8% 81.8%
======================================
Files 319 319
Lines 76120 76172 +52
======================================
+ Hits 62312 62374 +62
+ Misses 13808 13798 -10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated backport of pull request #10468 done by Mergify
Cherry-pick of 6c242f3 has failed:
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/