Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

[wip] Improve frozen abi coverage, docs and DX#11522

Closed
ryoqun wants to merge 11 commits intosolana-labs:masterfrom
ryoqun:frozen-abi-improvements
Closed

[wip] Improve frozen abi coverage, docs and DX#11522
ryoqun wants to merge 11 commits intosolana-labs:masterfrom
ryoqun:frozen-abi-improvements

Conversation

@ryoqun
Copy link
Copy Markdown
Contributor

@ryoqun ryoqun commented Aug 11, 2020 •
edited
Loading

Problem

wip

Summary of Changes

wip

Fixes #11047

follow up of: #8012

@ryoqun
Copy link
Copy Markdown
Contributor Author

ryoqun commented Aug 11, 2020

I'll prioritize other my prs over this as they're unblocked now. ;) This is just dump of my wip.

@ryoqun ryoqun added the CI Pull Request is ready to enter CI label Aug 11, 2020
@solana-grimes solana-grimes removed the CI Pull Request is ready to enter CI label Aug 11, 2020
@ryoqun ryoqun marked this pull request as ready for review August 11, 2020 05:10
@ryoqun ryoqun added the CI Pull Request is ready to enter CI label Aug 11, 2020
@solana-grimes solana-grimes removed the CI Pull Request is ready to enter CI label Aug 11, 2020
@ryoqun ryoqun added the CI Pull Request is ready to enter CI label Aug 11, 2020
@solana-grimes solana-grimes removed the CI Pull Request is ready to enter CI label Aug 11, 2020
@ryoqun ryoqun added the CI Pull Request is ready to enter CI label Aug 11, 2020
@solana-grimes solana-grimes removed the CI Pull Request is ready to enter CI label Aug 11, 2020
@ryoqun ryoqun force-pushed the frozen-abi-improvements branch from a9e36fc to 7acee3b Compare August 11, 2020 07:27
ryoqun added 3 commits August 11, 2020 17:18
@ryoqun
Fix too long file name
dd504d8
@ryoqun
update abi
4aa673e 
$ diff -u *5RMMcS7fSxHjCGAwwTiFSyoi3FKESCBkVoeBPspKJzp4* *8RYRhKQwGABY5hipqQvZMRrnzFxe3aE1sEFx1sgimFG2*
@@ -81,7 +81,7 @@
                     primitive str
                 field tpu_forwards: std::net::addr::SocketAddr
                     primitive str
-                field unused: std::net::addr::SocketAddr
+                field rpc_banks: std::net::addr::SocketAddr
                     primitive str
                 field rpc: std::net::addr::SocketAddr
                     primitive str
@@ -179,7 +179,7 @@
                     primitive str
                 field tpu_forwards: std::net::addr::SocketAddr
                     primitive str
-                field unused: std::net::addr::SocketAddr
+                field rpc_banks: std::net::addr::SocketAddr
                     primitive str
                 field rpc: std::net::addr::SocketAddr
                     primitive str
@@ -277,7 +277,7 @@
                     primitive str
                 field tpu_forwards: std::net::addr::SocketAddr
                     primitive str
-                field unused: std::net::addr::SocketAddr
+                field rpc_banks: std::net::addr::SocketAddr
                     primitive str
                 field rpc: std::net::addr::SocketAddr
                     primitive str
@@ -373,7 +373,7 @@
                     primitive str
                 field tpu_forwards: std::net::addr::SocketAddr
                     primitive str
-                field unused: std::net::addr::SocketAddr
+                field rpc_banks: std::net::addr::SocketAddr
                     primitive str
                 field rpc: std::net::addr::SocketAddr
                     primitive str
@@ -473,7 +473,7 @@
                     primitive str
                 field tpu_forwards: std::net::addr::SocketAddr
                     primitive str
-                field unused: std::net::addr::SocketAddr
+                field rpc_banks: std::net::addr::SocketAddr
                     primitive str
                 field rpc: std::net::addr::SocketAddr
                     primitive str
@@ -573,7 +573,7 @@
                     primitive str
                 field tpu_forwards: std::net::addr::SocketAddr
                     primitive str
-                field unused: std::net::addr::SocketAddr
+                field rpc_banks: std::net::addr::SocketAddr
                     primitive str
                 field rpc: std::net::addr::SocketAddr
                     primitive str
@ryoqun
update abi
7652e9e 
$ diff -u *92G1B1o9KCHpg75PRtao2mtJAni6cquVMtqxi8UNK1RW* *FY5mgiVVk1aoevvSYr8c6T58mNRneTfG2Su7WFG5pnSj*
@@ -17,7 +17,7 @@
                         field u8
                             primitive u8
                         field solana_sdk::instruction::InstructionError
-                            enum InstructionError (variants = 35)
+                            enum InstructionError (variants = 36)
                                 variant(0) GenericError (unit)
                                 variant(1) InvalidArgument (unit)
                                 variant(2) InvalidInstructionData (unit)
@@ -54,6 +54,7 @@
                                 variant(32) MissingAccount (unit)
                                 variant(33) ReentrancyNotAllowed (unit)
                                 variant(34) MaxSeedLengthExceeded (unit)
+                                variant(35) InvalidSeeds (unit)
                     variant(9) CallChainTooDeep (unit)
                     variant(10) MissingSignatureForFee (unit)
                     variant(11) InvalidAccountIndex (unit)
@stale
Copy link
Copy Markdown

stale Bot commented Aug 19, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale Bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Aug 19, 2020
@ryoqun ryoqun removed the stale [bot only] Added to stale content; results in auto-close after a week. label Aug 25, 2020
@stale
Copy link
Copy Markdown

stale Bot commented Sep 2, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale Bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Sep 2, 2020
@ryoqun ryoqun removed the stale [bot only] Added to stale content; results in auto-close after a week. label Sep 8, 2020
@stale
Copy link
Copy Markdown

stale Bot commented Sep 16, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale Bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Sep 16, 2020
@stale
Copy link
Copy Markdown

stale Bot commented Sep 23, 2020

This stale pull request has been automatically closed. Thank you for your contributions.

@stale stale Bot closed this Sep 23, 2020
@ryoqun ryoqun reopened this Sep 26, 2020
@stale stale Bot removed the stale [bot only] Added to stale content; results in auto-close after a week. label Sep 26, 2020
@ryoqun
Copy link
Copy Markdown
Contributor Author

ryoqun commented Sep 26, 2020 

[12:11 PM]
mvines | I'll never DM you:
@ryoqun - hey why does the Bank struct still need to be AbiExample?   We don't serde it directly anymore right?
[12:18 PM]
ryoqun:
Good question. Maybe I need to comment about that...  In short, it's needed to test abi digest with versioned serialized implementation: https://github.com/solana-labs/solana/blob/master/runtime/src/serde_snapshot/tests.rs#L266-L269
[12:19 PM]
ryoqun:
In some way, I might be able to lift that requirement; I'll try that at https://github.com/solana-labs/solana/pull/11522

@stale
Copy link
Copy Markdown

stale Bot commented Oct 3, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale Bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Oct 3, 2020
@stale
Copy link
Copy Markdown

stale Bot commented Oct 10, 2020

This stale pull request has been automatically closed. Thank you for your contributions.

@stale stale Bot closed this Oct 10, 2020
@ryoqun ryoqun reopened this Oct 13, 2020
@stale stale Bot removed the stale [bot only] Added to stale content; results in auto-close after a week. label Oct 13, 2020
@stale
Copy link
Copy Markdown

stale Bot commented Oct 20, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale Bot added the stale [bot only] Added to stale content; results in auto-close after a week. label Oct 20, 2020
@stale
Copy link
Copy Markdown

stale Bot commented Oct 28, 2020

This stale pull request has been automatically closed. Thank you for your contributions.

@stale stale Bot closed this Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

stale [bot only] Added to stale content; results in auto-close after a week.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

help devs with abi checks

2 participants

@ryoqun @solana-grimes