This repository was archived by the owner on Jan 22, 2025. It is now read-only.
fix rewards points (bp #10914)#11142
Merged
mergify[bot] merged 2 commits intov1.2from Jul 21, 2020
Merged
Conversation
* fix rewards points * fixups * * verify that we don't spend more in rewards than we've allocated for rewards * purge f64s from calculations that could be done with integers * test typical values * simplify iteration over delegations some * fixups * Use try_from * Add a comment for commission_split() * Add assertion to detect inconsistent reward dist. * Fix vote_balance_and_staked * Don't overwrite accounts with stale copies * Fix CI... * Add tests for vote_balance_and_staked * Add test for the determinism of update_rewards * Revert "Don't overwrite accounts with stale copies" This reverts commit 9886d08. * Make stake_delegation_accounts to return hashmap Co-authored-by: Ryo Onodera <ryoqun@gmail.com> (cherry picked from commit 7cc2a68) # Conflicts: # runtime/src/serde_snapshot/tests.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated backport of pull request #10914 done by Mergify
Cherry-pick of 7cc2a68 has failed:
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/