Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Ensure to digest non-empty snapshot_storages and add asserts#11021

Merged
mergify[bot] merged 2 commits intosolana-labs:masterfrom
ryoqun:snapshot-storage-abi
Jul 13, 2020
Merged

Ensure to digest non-empty snapshot_storages and add asserts#11021
mergify[bot] merged 2 commits intosolana-labs:masterfrom
ryoqun:snapshot-storage-abi

Conversation

@ryoqun
Copy link
Copy Markdown
Contributor

@ryoqun ryoqun commented Jul 13, 2020

Problem

Frozen ABI fails to emit error even if it should.

Summary of Changes

Just add assertions

Context (found via #10581)

@ryoqun ryoqun added the automerge Merge this Pull Request automatically once CI passes label Jul 13, 2020
@ryoqun ryoqun changed the title Snapshot storage abi Ensure to digest non-empty snapshot_storages and add asserts Jul 13, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 13, 2020

Codecov Report

Merging #11021 into master will decrease coverage by 0.0%.
The diff coverage is 86.3%.

@@            Coverage Diff            @@
##           master   #11021     +/-   ##
=========================================
- Coverage    82.1%    82.1%   -0.1%     
=========================================
  Files         318      318             
  Lines       73240    73247      +7     
=========================================
+ Hits        60195    60200      +5     
- Misses      13045    13047      +2     

@mergify mergify Bot merged commit de379a8 into solana-labs:master Jul 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

automerge Merge this Pull Request automatically once CI passes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant