Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Update spl-memo to fix windows linking error#10986

Closed
ryoqun wants to merge 1 commit intosolana-labs:masterfrom
ryoqun:spl-memo-linking-windows
Closed

Update spl-memo to fix windows linking error#10986
ryoqun wants to merge 1 commit intosolana-labs:masterfrom
ryoqun:spl-memo-linking-windows

Conversation

@ryoqun
Copy link
Copy Markdown
Contributor

@ryoqun ryoqun commented Jul 10, 2020

Problem

window build is broken, happening on master and v1.2: https://travis-ci.com/github/solana-labs/solana/jobs/359548827#L639

Summary of Changes

Update spl-memo

I've confirmed windows now builds at the other pr(#10983 with this commit included.). :): https://travis-ci.com/github/solana-labs/solana/jobs/359595539#L600

Context #10983

@ryoqun ryoqun added automerge Merge this Pull Request automatically once CI passes v1.2 labels Jul 10, 2020
@ryoqun
Copy link
Copy Markdown
Contributor Author

ryoqun commented Jul 10, 2020

btw, I've made updating a particular crate across the repository piece of cake:

$ ./scripts/cargo-for-all-lock-files.sh --ignore-exit-code update -p spl-memo --precise 1.0.1
++ dirname Cargo.lock
+ cd .
+ cargo update -p spl-memo --precise 1.0.1
    Updating crates.io index
      Adding solana-sdk-bpf-test v1.2.4
    Updating spl-memo v1.0.0 -> v1.0.1
++ dirname explorer/wasm/Cargo.lock
+ cd explorer/wasm
+ cargo update -p spl-memo --precise 1.0.1
error: package ID specification `spl-memo` matched no packages
./scripts/cargo-for-all-lock-files.sh: WARN: ignoring last cargo command failed exit code as requested: 101
++ dirname programs/bpf/Cargo.lock
+ cd programs/bpf
+ cargo update -p spl-memo --precise 1.0.1
error: package ID specification `spl-memo` matched no packages
./scripts/cargo-for-all-lock-files.sh: WARN: ignoring last cargo command failed exit code as requested: 101
++ dirname programs/librapay/Cargo.lock
+ cd programs/librapay
+ cargo update -p spl-memo --precise 1.0.1
error: package ID specification `spl-memo` matched no packages
./scripts/cargo-for-all-lock-files.sh: WARN: ignoring last cargo command failed exit code as requested: 101
++ dirname programs/move_loader/Cargo.lock
+ cd programs/move_loader
+ cargo update -p spl-memo --precise 1.0.1
error: package ID specification `spl-memo` matched no packages
./scripts/cargo-for-all-lock-files.sh: WARN: ignoring last cargo command failed exit code as requested: 101

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Jul 10, 2020

automerge label removed due to a CI failure

@mergify mergify Bot removed the automerge Merge this Pull Request automatically once CI passes label Jul 10, 2020
@ryoqun
Copy link
Copy Markdown
Contributor Author

ryoqun commented Jul 10, 2020

Oh, sad... Build failed on linux this time... ;)

@jackcmay It seems that solana-sdk-bpf-test has some problem on linux while it fixes windows build at #10983: https://buildkite.com/solana-labs/solana/builds/27274#4c826048-7fc2-48a8-ad5c-75c0f92627a9/76-461

@CriesofCarrots
Copy link
Copy Markdown
Contributor

Oh, sad... Build failed on linux this time... ;)

@jackcmay It seems that solana-sdk-bpf-test has some problem on linux while it fixes windows build at #10983: https://buildkite.com/solana-labs/solana/builds/27274#4c826048-7fc2-48a8-ad5c-75c0f92627a9/76-461

Yeah, it seems to be because of the two different versions of sdk and program-stubs (one in the crate, and an older dependency of spl-memo): https://discordapp.com/channels/428295358100013066/439194979856809985/728015602035327101

cc: #10986

@jackcmay
Copy link
Copy Markdown
Contributor

Fixed in #11000

@jackcmay jackcmay closed this Jul 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants