Change for cuda verify integration#109
Conversation
| pub fn verify(&self) -> bool { | ||
| match *self { | ||
| Event::Transaction(ref tr) => tr.verify(), | ||
| Event::Transaction(ref tr) => tr.verify_plan(), |
There was a problem hiding this comment.
This change shouldn't be necessary. Can you revert that and report back any consequences?
There was a problem hiding this comment.
I changed to verify_sig(), but did you mean it should be verify_sig() && verify_plan()? Anatoly removed the one that does both, but I can add it back.
|
|
||
| #[derive(Serialize, Deserialize, Debug, PartialEq, Eq, Clone)] | ||
| pub struct Transaction { | ||
| pub struct Signed { |
There was a problem hiding this comment.
Need to rename this to TransactionData
| #[derive(Serialize, Deserialize, Debug, PartialEq, Eq, Clone)] | ||
| pub struct Transaction { | ||
| pub struct Signed { | ||
| pub from: PublicKey, |
There was a problem hiding this comment.
Need to leave from in the top-level struct
Codecov Report
@@ Coverage Diff @@
## master #109 +/- ##
==========================================
- Coverage 96.09% 95.29% -0.81%
==========================================
Files 16 17 +1
Lines 1358 1467 +109
==========================================
+ Hits 1305 1398 +93
- Misses 53 69 +16
Continue to review full report at Codecov.
|
|
I didn't include the GPU lib, do we want to just check it in for now? |
|
The functionality tucked under feature flags don't need to be buildable by CI. This PR is good to go. Merging. |
Bumps [eslint](https://github.com/eslint/eslint) from 6.8.0 to 7.4.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](eslint/eslint@v6.8.0...v7.4.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
3 participants
No description provided.