Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purge TransactionStatus and AddressSignatures exactly from ledger-tool (bp #10358) #10376

Merged
merged 1 commit into from
Jun 3, 2020

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 3, 2020

This is an automated backport of pull request #10358 done by Mergify

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the simulator.

Finally, you can contact us on https://mergify.io/

#10358)

* Add failing test

* Add execution path to purge primary-index columns exactly

* Fail gracefully if older TransactionStatus rocksdb keys are present

* Remove columns_empty check for special columns

* Move blockstore purge methods to submodule

* Remove unused column empty check

(cherry picked from commit eee9a08)
@mergify mergify bot added the automerge Merge this Pull Request automatically once CI passes label Jun 3, 2020
@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #10376 into v1.2 will increase coverage by 0.0%.
The diff coverage is 93.4%.

@@           Coverage Diff           @@
##            v1.2   #10376    +/-   ##
=======================================
  Coverage   81.4%    81.5%            
=======================================
  Files        289      290     +1     
  Lines      67147    67447   +300     
=======================================
+ Hits       54686    54984   +298     
- Misses     12461    12463     +2     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants