Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct comment stating lockup gates stake authorize ixs #10063

Merged
merged 2 commits into from
May 15, 2020

Conversation

jstarry
Copy link
Member

@jstarry jstarry commented May 15, 2020

Problem

Lockup doesn't prevent re-authorization but some comments say they do

Summary of Changes

  • Update comments
  • Delete dead code

Fixes #

@jstarry jstarry requested a review from garious May 15, 2020 10:11
@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #10063 into master will decrease coverage by 0.1%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #10063     +/-   ##
=========================================
- Coverage    81.5%    81.4%   -0.2%     
=========================================
  Files         283      283             
  Lines       65782    65757     -25     
=========================================
- Hits        53660    53572     -88     
- Misses      12122    12185     +63     

Copy link
Contributor

@garious garious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Near heart attack seeing that dead code. I checked the withdraw implementation and happy to see all the right safeguards and tests were in place and that code was indeed redundant.

@jstarry
Copy link
Member Author

jstarry commented May 15, 2020

Near heart attack seeing that dead code

Same 😨

@jstarry jstarry merged commit b762319 into solana-labs:master May 15, 2020
@jstarry jstarry deleted the fix-old-comment branch May 15, 2020 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants