Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(experimental): optimise signTransaction to only encode the message once #1789

Merged
merged 1 commit into from
Oct 27, 2023
Merged

refactor(experimental): optimise signTransaction to only encode the message once #1789

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions packages/transactions/src/signatures.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { isSignerRole } from '@solana/instructions';
import { Ed25519Signature, signBytes } from '@solana/keys';

import { ITransactionWithFeePayer } from './fee-payer';
import { CompiledMessage, compileMessage } from './message';
import { compileMessage } from './message';
import { getCompiledMessageEncoder } from './serializers/message';

export interface IFullySignedTransaction extends ITransactionWithSignatures {
Expand Down Expand Up @@ -63,12 +63,6 @@ export function isTransactionSignature(
return true;
}

async function getCompiledMessageSignature(message: CompiledMessage, secretKey: CryptoKey) {
const wireMessageBytes = getCompiledMessageEncoder().encode(message);
const signature = await signBytes(secretKey, wireMessageBytes);
return signature;
}

export function getSignatureFromTransaction(
transaction: ITransactionWithFeePayer & ITransactionWithSignatures
): TransactionSignature {
Expand All @@ -91,12 +85,10 @@ export async function signTransaction<TTransaction extends Parameters<typeof com
const compiledMessage = compileMessage(transaction);
const nextSignatures: Record<Base58EncodedAddress, Ed25519Signature> =
'signatures' in transaction ? { ...transaction.signatures } : {};
const wireMessageBytes = getCompiledMessageEncoder().encode(compiledMessage);
const publicKeySignaturePairs = await Promise.all(
keyPairs.map(keyPair =>
Promise.all([
getAddressFromPublicKey(keyPair.publicKey),
getCompiledMessageSignature(compiledMessage, keyPair.privateKey),
])
Promise.all([getAddressFromPublicKey(keyPair.publicKey), signBytes(keyPair.privateKey, wireMessageBytes)])
)
);
for (const [signerPublicKey, signature] of publicKeySignaturePairs) {
Expand Down