refactor(experimental): add unit tests for getAccountInfo RPC method #1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcintyre94
force-pushed
the
get-account-info-tests
branch
from
667e7b5
to
cfa015e
Compare
steveluscher
requested changes
Jul 6, 2023
| describe('for an account with parse-able JSON data', () => { | ||
| // TODO: not sure how to do this in the test validator | ||
| // Creating an account with data from a mainnet stake account doesn't work | ||
| // I think the testnet validator might not have the parsers? |
There was a problem hiding this comment.
I just tried this and it worked.
- Find an account that definitely parses on mainnet (eg.
CSg2vQGbnwWdSyJpwK4i3qGfB6FebaV3xQTx4U1MbixN) solana-test-validator -u m --clone CSg2vQGbnwWdSyJpwK4i3qGfB6FebaV3xQTx4U1MbixN
curl http://localhost:8899 -X POST -H "Content-Type: application/json" -d '
{
"jsonrpc": "2.0",
"id": 1,
"method": "getAccountInfo",
"params": [
"CSg2vQGbnwWdSyJpwK4i3qGfB6FebaV3xQTx4U1MbixN",
{ "encoding": "jsonParsed" }
]
}
'
There was a problem hiding this comment.
Thanks for the pointer! Figured it out, I was using the wrong owner in the fixture and I guess it uses that to figure out how to parse the account. Makes sense!
mcintyre94
force-pushed
the
get-account-info-tests
branch
from
cfa015e
to
378819a
Compare
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds unit tests for the
getAccountInfoRPC call. I'm probably going to end up refactoring this a bit to addgetMultipleAccountsandgetProgramAccountsso I want some tests firstNote that I've been unable to test the
jsonParsedfully. I tried copying the data from a mainnet stake account (wherejsonParsedworks) into a fixture, but requestingjsonParsedencoding just returns the base64 encoding. I'm not sure if the test validator is missing the parsers?