Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tlv: fix typos, update example code in README.md #7106

Merged
merged 10 commits into from
Aug 5, 2024

Conversation

jacksondoherty
Copy link
Contributor

No description provided.

@mergify mergify bot added the community Community contribution label Aug 4, 2024
@jacksondoherty jacksondoherty changed the title Fix typo in tlv README tlv: Fix typo in README.md Aug 4, 2024
@jacksondoherty jacksondoherty changed the title tlv: Fix typo in README.md tlv: Fix typos in README.md Aug 4, 2024
@jacksondoherty jacksondoherty marked this pull request as draft August 4, 2024 20:35
@jacksondoherty jacksondoherty changed the title tlv: Fix typos in README.md tlv: fix typos, update example code in README.md Aug 4, 2024
@jacksondoherty jacksondoherty marked this pull request as ready for review August 4, 2024 22:14
Copy link
Contributor

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! Just one request for updating the comment, even though I know you didn't add it!

libraries/type-length-value/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@buffalojoec buffalojoec merged commit 4a7faf8 into solana-labs:master Aug 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants