This repository was archived by the owner on Mar 11, 2025. It is now read-only.
get 'map_transaction_error' return value consistent#6277
Merged
yihau merged 1 commit intosolana-labs:masterfrom Feb 20, 2024
Merged
get 'map_transaction_error' return value consistent#6277yihau merged 1 commit intosolana-labs:masterfrom
yihau merged 1 commit intosolana-labs:masterfrom
Conversation
9ce468c to
f98fa2b
Compare
SebastianBor
approved these changes
Feb 20, 2024
Contributor
|
@yihau will the sdk change break all downstream users of this error variant? If so, we should highlight it in the changelog. I can put in a PR for that |
Contributor
Author
|
not sure if it is a breaking change. it's more like we add two more error types 🤔 the original: solana-labs/solana#35113 but I guess it won't be wrong to put more info in changelog haha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the details is in the code comment 🙈 copy them here for easier reading: