feat: add getRecentPrioritizationFees API #1233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…forward an empty array to the RPC
steveluscher
approved these changes
Apr 4, 2023
| async getRecentPrioritizationFees( | ||
| publicKeys?: PublicKey[], | ||
| ): Promise<RecentPrioritizationFees[]> { | ||
| const keys = publicKeys ? publicKeys?.map(key => key.toBase58()) : []; |
Contributor
There was a problem hiding this comment.
According to the spec, I think this should be undefined when:
- No keys were supplied.
- A zero-length array was supplied.
| }); | ||
|
|
||
| it('get recent prioritization fee', async () => { | ||
| if (mockServer) { |
Contributor
There was a problem hiding this comment.
Usually we let these run in live mode, and just assert on the return values being numeric.
steveluscher
added
automerge
Contributor
|
🎉 This PR is included in version 1.75.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
steveluscher
modified the milestones:
web3.js Roadmap – March 2023,
web3.js Roadmap – April 2023
Contributor
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1095