SIMD-0093: Disable bpf loader (V2) instructions #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaoranYi
force-pushed
the
disable_bpf_loader_inst
branch
from
6d378c7
to
488b251
Compare
HaoranYi
changed the title
HaoranYi
force-pushed
the
disable_bpf_loader_inst
branch
from
488b251
to
1be9a5b
Compare
HaoranYi
changed the title
brooksprumo
reviewed
Dec 18, 2023
|
|
||
| ## Summary | ||
|
|
||
| Add a new feature to disable Bpf loader V2 program deployment. |
There was a problem hiding this comment.
I know in the Solana Labs code we call these feature gates. Maybe this is sufficiently client-agnostic and should be used here too?
Suggested change
| Add a new feature to disable Bpf loader V2 program deployment. | |
| Add a new feature gate to disable Bpf loader V2 program deployment. |
Or even remove "feature" entirely:
Disable BPF Loader V2 for program deployment.
I think that's my preferred one.
There was a problem hiding this comment.
We use the same terminology and feature gating structure on FD
Comment on lines
17
to
27
| ## Motivation | ||
|
|
||
| We want to deprecate the usage of *executable* metadata on account for program | ||
| runtime. The new variant of Bpf loader (i.e. V3/V4 etc.) no longer requires | ||
| *executable* metadata. However, the old Bpf loader (v2) still use *executable* | ||
| metadata during its program deployment. And this is a blocker for deprecating | ||
| the usage of *executable* metadata for program runtime. Therefore, as we are | ||
| migrating from the old Bpf loader V2 to the new Bpf loader (V3/V4), we are going | ||
| to add a feature to disable old V2 Bpf program deployment so that we can | ||
| activate the feature and deprecate *executable* metadata in program runtime for | ||
| the new kinds of Bpf loaders. |
There was a problem hiding this comment.
The current wording requires that the reader knows what "executable metadata" is. Wdyt about first defining what "executable metadata" is?
Co-authored-by: Brooks <[email protected]>
Co-authored-by: Brooks <[email protected]>
Co-authored-by: Brooks <[email protected]>
Co-authored-by: Brooks <[email protected]>
ripatel-fd
approved these changes
Dec 29, 2023
lheeger-jump
changed the title
|
I will merge this SIMD, barring core contributor objections, on 11/01/2024, or as soon as labs signs off. |
Lichtso
approved these changes
Jan 6, 2024
|
I don't have write access to this repo. Can someone with write access to merge the PR? |
|
Looks like we've reached consensus. Thanks @HaoranYi! |
jeffwashington
requested review from
jeffwashington
and removed request for
jeffwashington
|
Looks good! |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add disable bpf loader (V2) instructions simd