Skip to content

SIMD-0291: Commission Rate in Basis Points#291

Merged
Benhawkins18 merged 3 commits intosolana-foundation:mainfrom
jstarry:commission-rate-bps
Jul 31, 2025
Merged

SIMD-0291: Commission Rate in Basis Points#291
Benhawkins18 merged 3 commits intosolana-foundation:mainfrom
jstarry:commission-rate-bps

Conversation

@jstarry
Copy link
Copy Markdown
Contributor

@jstarry jstarry commented May 29, 2025

No description provided.

@jstarry jstarry force-pushed the commission-rate-bps branch from 3123097 to 24984fd Compare May 29, 2025 22:27
@jstarry jstarry changed the title SIMD-XXX: Commission Rate in Basis Points SIMD-0291: Commission Rate in Basis Points May 29, 2025
joncinque
joncinque previously approved these changes May 30, 2025
Copy link
Copy Markdown
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Copy Markdown
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@dimandotsol
Copy link
Copy Markdown

Personally, I don’t like the use of the term “basis points” - I would prefer to stick to mathematical terminology.

@Benhawkins18 Benhawkins18 merged commit edfd2e3 into solana-foundation:main Jul 31, 2025
2 checks passed
@jstarry jstarry deleted the commission-rate-bps branch August 1, 2025 02:25
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jan 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants