SIMD-0138: Deprecate legacy vote instructions#138
SIMD-0138: Deprecate legacy vote instructions#138lheeger-jump merged 2 commits intosolana-foundation:mainfrom
Conversation
AshwinSekar
force-pushed
the
deprecate-vote-ixs
branch
from
ab35ed5 to
2af43f2
Compare
AshwinSekar
changed the title
AshwinSekar
force-pushed
the
deprecate-vote-ixs
branch
from
c0fd383 to
aa5cc85
Compare
| Implementations should ensure that the `TowerSync` instruction has been | ||
| activated before enabling the `deprecate legacy vote instructions` feature, | ||
| in order to ensure that at least one vote instruction available for the client. |
There was a problem hiding this comment.
Do you mind specifying which feature gate the TowerSync instruction is gated by?
| Implementations should ensure that the `TowerSync` instruction has been | ||
| activated before enabling the `deprecate legacy vote instructions` feature, | ||
| in order to ensure that at least one vote instruction available for the client. |
There was a problem hiding this comment.
Minor nit: this isn't really down to the implementation, as feature activations are cluster-wide.
If you do mean that each client implementation should explicitly do this check, could you explicitly state that, and specify what happens if this check fails? If not, could you re-word to make it clear that this is the responsibility of the feature activator?
Thanks! 🙇
There was a problem hiding this comment.
updated to be clear on the interaction of these 2 features
|
@jacobcreech @0xSol We have consensus on the Anza & Firedancer side. Suggest we give this SIMD 1 week time for community comments and then merge. |
Alright, we'll merge on April 18th, 2024 if no other comments against this come up. |
lheeger-jump
changed the title
|
Merging, no new comments. |
6 participants
Part of the anza-xyz/agave#2597 effort