Skip to content

Add SIMD-0001: A process for improvements#1

Merged
jacobcreech merged 1 commit into
solana-foundation:mainfrom
jacobcreech:main
Dec 9, 2022
Merged

Add SIMD-0001: A process for improvements#1
jacobcreech merged 1 commit into
solana-foundation:mainfrom
jacobcreech:main

Conversation

@jacobcreech
Copy link
Copy Markdown
Contributor

Current Proposal Process Shortfalls

The current proposal process is as follows:

  1. Discuss across core engineering about a proposed feature in Discord and/or
    github issue(s).
  2. Create a proposal document under
    docs/src/proposals.
  3. Review is done by core engineering + community members
  4. PR Is pulled into Accepted Design proposals and live on Solana
    Docs
  5. If required, a feature-gate issue is created and kept up-to-date to track
    the feature's activation.
  6. If the proposal needs to be tweaked, submit a new PR and have the change
    reviewed by the same group in step 3.
  7. Once implementation is complete, submit a PR that moves the link from
    Accepted Design Proposals to Implemented Proposals.

While this is a good flow to fast iteration, there are a few shortfalls:

  • Not all implementation proposals make it to the docs
  • Design documents don't have any standard format and miss a lot of information
  • Discussion and feature-gating are difficult to keep track of by community

Proposal for process:

  • New site dedicated to proposals
  • Have a more formal process for proposing new features
  • Consensus is owned by core contributors.

The main changes to the current process:

  • More formalized documentation standard
  • New site

The process proposed was based on both RFC and EIP.

@ripatel-fd
Copy link
Copy Markdown
Contributor

I think we should call this SIMD-0000 because array indexes begin with zero

Comment thread proposals/0001-simd-process.md Outdated
@jacobcreech
Copy link
Copy Markdown
Contributor Author

I think we should call this SIMD-0000 because array indexes begin with zero

Don't have any strong feels on the 0001. Updated to 0000

Copy link
Copy Markdown
Contributor

@riptl riptl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it?

Comment thread XXXX-template.md Outdated
@willhickey
Copy link
Copy Markdown
Contributor

Thanks for working on this!

I'm curious, what's the motivation for making a new site?

Do you have a vision yet for where the new site will be hosted, who will own it, how proposals will be added and updated?

@jacobcreech
Copy link
Copy Markdown
Contributor Author

Thanks for working on this!

I'm curious, what's the motivation for making a new site?

Do you have a vision yet for where the new site will be hosted, who will own it, how proposals will be added and updated?

A new site is required to be separate from the original Labs proposal process and be dedicated to proposals only. The proposals will be added under /proposals/ and auto-added once accepted a lot like how the EIP manages their site. I need to get the site part completed still.

New site would be hosts at simd.solana.com and be owned by Solana Foundation.

@willhickey
Copy link
Copy Markdown
Contributor

willhickey commented Dec 5, 2022

Ok moving the process over to Foundation makes sense.

Not all implementation proposals make it to the docs

Do we have guidance on what changes will require a proposal?

@jacobcreech
Copy link
Copy Markdown
Contributor Author

Do we have guidance on what changes will require a proposal?

There's some guidance here. For example, every feature today would have a proposal.

@mvines
Copy link
Copy Markdown
Contributor

mvines commented Dec 6, 2022

I'd like to find a different term than SIMD for all this.
Google "SIMD"...

Comment thread proposals/0000-simd-process.md
Comment thread proposals/0000-simd-process.md
@jacobcreech jacobcreech changed the title Add SIMD-0001: A process for improvements Add SIMD-0000: A process for improvements Dec 8, 2022
@jacobcreech jacobcreech force-pushed the main branch 2 times, most recently from 0ab807c to fea5d75 Compare December 8, 2022 03:20
Comment thread XXXX-template.md
Comment thread XXXX-template.md Outdated
Comment thread proposals/0000-simd-process.md
@jacobcreech jacobcreech force-pushed the main branch 2 times, most recently from fdc4576 to 7106c3a Compare December 8, 2022 22:31
@jacobcreech jacobcreech changed the title Add SIMD-0000: A process for improvements Add SIMD-0001: A process for improvements Dec 8, 2022
@jacobcreech
Copy link
Copy Markdown
Contributor Author

Planning on getting this merged to be battle tested/start updating at 3pm PST, December 9th, 2022. Last call for concerns or updates.

Comment thread proposals/0001-simd-process.md Outdated
Comment thread proposals/0001-simd-process.md Outdated
Comment thread proposals/0001-simd-process.md Outdated
integrating feedback. The most relevant core contributors to the proposal
should be included in the review process. Review will take place completely
through Github so that all comments are collected and documented. Once
consensus is met by the core contributors, the proposal can either be accepted
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is consensus reached or measured? This seems like the most important part of this new process.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added more information about consensus. While it is important, I am trying to avoid defining what consensus looks like, other than as a social construct. I want the process of proposals to be very similar to how it is today, driven by the norms of core contributors, and not impose more structure than is necessary.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think consensus on proposals, at least on the activation thereof, should be migrated to on-chain voting by means of stake-weighted realms DAO. Right now the on-chain voting is severely lacking both in application and functionality, as it requires a cumbersome CLI-driven token transfer and provides no opportunity to dissent and little access or insight into voting record or history.

A Realms DAO can be created where voting power is synchronized to stake-weight every epoch, feature activation should require a majority of stake to vote in favour of it. Currently the momentum of upgrading to a feature-including version forces validators to comply with no opportunity to dissent, the only option is "don't adopt a change you don't agree with" which however means suicide as one can no longer participate in the chain. An opportunity to openly and transparently vote and express assent or dissent is needed.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michaelh-laine I agree with your sentiment on wanting to be able to have a voice and that there should be more around feature activations. For this proposal I'd like to stay on the process of proposals vs the implementation and activation.

Update simd-0001 with mermaid markdown diagrams

update to use frontmatter on SIMDs

update simd-0001 to use frontmatter

Addressing comments on structure

Update simd structure

update simd number to 0001

Add info on consensus for simd-0001
@IntokuSatori
Copy link
Copy Markdown

I'd like to find a different term than SIMD for all this. Google "SIMD"...

Agreed, very confusing as a hardware guy. Makes me think of GPUs.

@mvines
Copy link
Copy Markdown
Contributor

mvines commented Dec 9, 2022

I'd like to find a different term than SIMD for all this. Google "SIMD"...

Agreed, very confusing as a hardware guy. Makes me think of GPUs.

Apparently people think the confusion is good :)

@jacobcreech
Copy link
Copy Markdown
Contributor Author

jacobcreech commented Dec 9, 2022

Apparently people think the confusion is good :)

Not my intention to be confusing. We can update, especially this early in the process

@jacobcreech jacobcreech merged commit 9b7a2bb into solana-foundation:main Dec 9, 2022
MaxResnick pushed a commit to MaxResnick/solana-improvement-documents that referenced this pull request Jan 29, 2025
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jan 12, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.