Bugfix/audit report missing fixes

[dev-jodee]

Important

Update dependencies, improve error handling, enhance validation logic, and refine transaction and token handling across modules.

• Dependencies:
  • Update Cargo.lock to remove unused dependencies and add new ones like bitvec, bytecheck, rust_decimal, etc.
  • Remove jup-ag from Cargo.toml and crates/lib/Cargo.toml.
• Error Handling:
  • Remove ThreadSafetyError from KoraError in error.rs.
  • Improve error messages in account_validator.rs for executable flag mismatches.
• Validation:
  • Add Default derive to several policy structs in config.rs.
  • Update CacheValidator to handle Redis connection errors more gracefully.
  • Enhance ConfigValidator to include warnings for insecure configurations.
• Transaction and Token Handling:
  • Change fee calculation in fee.rs to return u64 instead of f64.
  • Use Decimal for price calculations in token.rs and oracle.rs.
  • Refactor verify_token_payment in token.rs to improve logic.
• Testing:
  • Update integration tests in integration.test.ts to remove redundant checks.
  • Add new test cases in jupiter_integration.rs for price validation.
  • Modify test configurations in tests/Cargo.toml to include new dependencies.

^{This description was created by for 102945a. You can customize this summary. It will automatically update as commits are pushed.}

📊 Unit Test Coverage

Unit Test Coverage: 80.3%

View Detailed Coverage Report

[github-actions]

📊 TypeScript Coverage Report

Coverage: 82.0%

View detailed report

Coverage artifacts have been uploaded to this workflow run.
View Artifacts

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed everything up to 102945a in 1 minute and 56 seconds. Click for details.

• Reviewed 2824 lines of code in 27 files
• Skipped 0 files when reviewing.
• Skipped posting 9 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. crates/lib/src/signer/pool.rs:152

• Draft comment:
  Use 'rand::thread_rng()' and 'rng.gen_range(...)' instead of 'rand::rng()' and 'rng.random_range(...)'. The current API may be non‐standard or deprecated.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

2. crates/lib/src/rpc_server/auth.rs:76

• Draft comment:
  Good use of constant‐time comparison to mitigate timing attacks.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

3. crates/lib/src/validator/transaction_validator.rs:141

• Draft comment:
  Consider refactoring the long validation logic into smaller helper functions to improve maintainability.
• Reason this comment was not posted:
  Confidence changes required: 50% <= threshold 50% None

4. crates/lib/src/token/token.rs:98

• Draft comment:
  Ensure that conversion from u64 to Decimal and back handles edge cases properly and consider logging conversion errors for better debugging.
• Reason this comment was not posted:
  Confidence changes required: 30% <= threshold 50% None

5. tests/external/jupiter_integration.rs:60

• Draft comment:
  Integration tests depend on live Jupiter API responses. Consider mocking network responses or using a sandbox environment to reduce flakiness.
• Reason this comment was not posted:
  Comment was on unchanged code.

6. sdks/ts/test/integration.test.ts:50

• Draft comment:
  The tests assert that various configuration fields are defined. Verify that edge cases (e.g. empty arrays or zero limits) are also tested.
• Reason this comment was not posted:
  Confidence changes required: 20% <= threshold 50% None

7. tests/Cargo.toml:43

• Draft comment:
  Dependency versions appear consistent; ensure workspace dependencies are kept up-to-date.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

8. crates/lib/src/validator/config_validator.rs:148

• Draft comment:
  Consider adding more detailed logging during configuration validation to aid troubleshooting in production.
• Reason this comment was not posted:
  Confidence changes required: 30% <= threshold 50% None

9. Cargo.lock:4361

• Draft comment:
  Typo alert: The dependency named "rend" on this line seems suspicious. Could it be a typo for "rand" (or another intended crate name)? Please verify the correct spelling.
• Reason this comment was not posted:
  Comment looked like it was already resolved.

Workflow ID: wflow_OgvFNQGuTydJBqu5

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}